Resolve review comments

apache · Sep 30, 2019 · 384c960 · 384c960
1 parent 73e6625
commit 384c960
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 16 deletions.
diff --git a/ci/travis_script_python.sh b/ci/travis_script_python.sh
@@ -168,7 +168,6 @@ export PYARROW_BUILD_TYPE=$ARROW_BUILD_TYPE
 export PYARROW_WITH_PARQUET=1
 export PYARROW_WITH_PLASMA=1
 export PYARROW_WITH_ORC=1
-export PYARROW_WITH_S3=1
 if [ "$ARROW_TRAVIS_S3" == "1" ]; then
   export PYARROW_WITH_S3=1
 fi

diff --git a/python/pyarrow/_s3fs.pyx b/python/pyarrow/_s3fs.pyx
@@ -154,21 +154,9 @@ cdef class S3FileSystem(FileSystem):
 
     Parameters
     ----------
-    access_key: str, default None
-        AWS Access Key ID. Pass None to use the standard AWS environment
-        variables and/or configuration file.
-    secret_key: str, default None
-        AWS Secret Access key. Pass None to use the standard AWS environment
-        variables and/or configuration file.
-    region: str, default 'us-east-1'
-        AWS region to connect to.
-    scheme: str, default 'https'
-        S3 connection transport scheme.
-    endpoint_override: str, default None
-        Override region with a connect string such as "localhost:9000"
-    background_writes: boolean, default True
-        Whether OutputStream writes will be issued in the background, without
-        blocking.
+    options: S3Options, default None
+        Options for connecting to S3. If None is passed then attempts to
+        initialize the connection from AWS environment variables.
     """
 
     cdef: