validate callback

apache · Mar 10, 2020 · 035024f · 035024f
1 parent e791c62
commit 035024f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/dev/archery/archery/bot.py b/dev/archery/archery/bot.py
@@ -78,6 +78,8 @@ class CommentBot:
 
     def __init__(self, name, handler, token=None):
         # TODO(kszucs): validate
+        assert isinstance(name, str)
+        assert callable(self.handler)
         self.name = name
         self.handler = handler
         self.github = github.Github(token)

diff --git a/dev/archery/archery/cli.py b/dev/archery/archery/cli.py
@@ -598,7 +598,7 @@ def integration(with_all=False, random_seed=12345, **args):
 def trigger_bot(event_name, event_payload, arrow_token, crossbow_token):
     event_payload = json.loads(event_payload.read())
 
-    bot = CommentBot(name='ursabot', handler='ursabot', token=arrow_token)
+    bot = CommentBot(name='ursabot', handler=ursabot, token=arrow_token)
     bot.handle(event_name, event_payload)