Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Fix bug in temporal utilities due to DST being ignored. to active_release #967

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 22, 2021

Automatic cherry-pick of 9703f98

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 22, 2021
@alamb
Copy link
Contributor Author

alamb commented Nov 22, 2021

Failing due to #969 -- will rebase when the fix for that gets backported

* Check behaviour of temporal utilities for DST.

* Fix temporal util bug ignoring dst.

* Refactor macro for efficiency.
@codecov-commenter
Copy link

Codecov Report

Merging #967 (ae031e0) into active_release (e6c5e1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ae031e0 differs from pull request most recent head 0d6a96f. Consider uploading reports for the commit 0d6a96f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           active_release     #967   +/-   ##
===============================================
  Coverage           82.31%   82.32%           
===============================================
  Files                 168      168           
  Lines               48694    48692    -2     
===============================================
+ Hits                40083    40086    +3     
+ Misses               8611     8606    -5     
Impacted Files Coverage Δ
arrow/src/compute/kernels/temporal.rs 97.35% <100.00%> (+1.27%) ⬆️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.46%) ⬇️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.27%) ⬆️
arrow/src/datatypes/field.rs 53.68% <0.00%> (+0.30%) ⬆️
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c5e1c...0d6a96f. Read the comment docs.

@alamb alamb merged commit 9d453a3 into active_release Nov 23, 2021
@alamb alamb deleted the cherry_pick_9703f989 branch November 23, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants