-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable test under MIRI which appears to exceed memory limits intermittently on github CI #910
Conversation
Bah, now it blows up somewhere else later: https://github.com/apache/arrow-rs/runs/4097468828?check_suite_focus=true |
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 82.29% 82.30%
=======================================
Files 168 168
Lines 48028 48028
=======================================
+ Hits 39527 39529 +2
+ Misses 8501 8499 -2
Continue to review full report at Codecov.
|
Have we tried different Rust versions? |
yes i think by default this runs on latest nightly |
Yeah, I tried latest nightly in #907 which did not seem to solve the issue either. |
I am considering adding a loop that retries running MIRI a few times to see if we can get a successful run. Not the most elegant of solutions, but one that has worked for me it the past. New PR shortly |
How about sharding the Miri tests so that no container runs too many tests |
Which issue does this PR close?
Closes #879
Rationale for this change
The MIRI CI check is failing intermittently on master. The symptoms of the failing MIRI tests seem to be the same as would happen if miri is killed by the github OOM killer -- see #879 (comment)
We can't reproduce any MIRI failures locally so this seems like either a bug in MIRI or it is using too many resources for github.
Note the test in question was added relatively recently in #706 by @b41sh (but then MIRI started failing after updating to a new rust version)
What changes are included in this PR?
Disable the failing test
Are there any user-facing changes?
No