-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some clippy warnings #896
Conversation
@@ -319,7 +319,7 @@ impl TreeBuilder { | |||
/// Reader tree for record assembly | |||
pub enum Reader { | |||
// Primitive reader with type information and triplet iterator | |||
PrimitiveReader(TypePtr, TripletIter), | |||
PrimitiveReader(TypePtr, Box<TripletIter>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduce enum size
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 82.30% 82.30%
=======================================
Files 168 168
Lines 48031 48026 -5
=======================================
- Hits 39533 39529 -4
+ Misses 8498 8497 -1
Continue to review full report at Codecov.
|
Merged to master |
Co-authored-by: Jiayu Liu <[email protected]>
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?