-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps to upgrade tonic / prost / prost-derive #864
Conversation
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Integration Test failed
tonic v0.6.0 need rust 1.56+ (edition2021), but it looks https://github.com/apache/arrow/blob/68a081acc4d0e2c85a6469ca165444df6d965d2b/ci/docker/conda-integration.dockerfile#L42 only get 1.55 cc @alamb @nevi-me , I am not familiar with conda-integration, maybe you guys can help me |
Done. |
Signed-off-by: Chojan Shang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #864 +/- ##
==========================================
- Coverage 82.46% 82.30% -0.16%
==========================================
Files 168 168
Lines 48175 48093 -82
==========================================
- Hits 39726 39585 -141
- Misses 8449 8508 +59
Continue to review full report at Codecov.
|
https://github.com/PsiACE/arrow-rs/runs/4022900917?check_suite_focus=true re-run
https://issues.apache.org/jira/browse/ARROW-14489 , thanks @jimexist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PsiACE -- this looks great
So since these are non minor version updates I think this is basically a non-backwards compatible set of changes -- so I can't backport them to the arrow 6.x line, but they'll be released in 7.0 I merged master to make sure that this is still good and will merge if it passes |
MIRI failure tracked by #879 |
Merged again to see if we can get a clean passing run |
Thanks again @PsiACE |
* Bump deps Signed-off-by: Chojan Shang <[email protected]> * Setup lastest cargo-tarpaulin Signed-off-by: Chojan Shang <[email protected]> * Try to use the lastest cargo Signed-off-by: Chojan Shang <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Which issue does this PR close?
Closes #897
Rationale for this change
prost and tonic have recently had some updates
What changes are included in this PR?
Are there any user-facing changes?
I guess no changes