Upgrade lexical-core to 0.8 #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
Sep 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
=======================================
Coverage 82.47% 82.47%
=======================================
Files 168 168
Lines 47715 47715
=======================================
Hits 39353 39353
Misses 8362 8362
Continue to review full report at Codecov.
|
houqp
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #747
Rationale for this change
Upgrade to latest version, which has some performance improvements (usage of Eisel-Lemire algorithm being one important change)
See:
https://github.com/Alexhuszagh/rust-lexical/releases/tag/v0.8.0
What changes are included in this PR?
Are there any user-facing changes?