Add append_nulls and append_trusted_len_iter to PrimitiveBuilder
#728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 82.50% 82.52% +0.02%
==========================================
Files 168 168
Lines 47589 47691 +102
==========================================
+ Hits 39261 39356 +95
- Misses 8328 8335 +7
Continue to review full report at Codecov.
|
alamb
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
This looks good to me. Thank you @bjchambers
@nevi-me or @jorgecarleitao do you have any thoughts on adding this API. While it is unsafe it seems like there is more than sufficient existing precedent for this type of API
|
Merging this in. Thanks @bjchambers ! Sorry for the delay in merging I have been on vacation and am now catching up. |
alamb
pushed a commit
that referenced
this pull request
Sep 9, 2021
#728) * stub out impl * mark unsafe * add tests
alamb
added a commit
that referenced
this pull request
Sep 10, 2021
#728) (#759) * stub out impl * mark unsafe * add tests Co-authored-by: Ben Chambers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #725.
Rationale for this change
Allows appending multiple values / nulls in a single call. This avoids re-checking capacity, etc.
What changes are included in this PR?
Adds
append_nullsandappend_trusted_len_itermethods toPrimitiveBuilder.Are there any user-facing changes?