Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add example for creating SchemaDescriptor #6841

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 5, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

While workign on #6840 I found it very fiddly to understand to make a SchemaDescriptor in an example

It would have been nice to have an example in the docs. Let's add one

What changes are included in this PR?

Add an example of creating SchemaDescriptor in the docs

Are there any user-facing changes?

Just docs, no behavior changes

@alamb alamb changed the title Add example for creating SchemaDescriptor Minor: add example for creating SchemaDescriptor Dec 5, 2024
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@alamb alamb added documentation Improvements or additions to documentation parquet Changes to the parquet crate labels Dec 6, 2024
@alamb
Copy link
Contributor Author

alamb commented Dec 6, 2024

Thank you for the reviews @etseidl and @tustvold

@alamb alamb merged commit ed8996b into apache:main Dec 6, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants