Support for casting StringViewArray to DecimalArray
#6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <[email protected]>
Omega359
reviewed
Nov 12, 2024
arrow-cast/src/cast/mod.rs
Outdated
| @@ -2483,14 +2484,28 @@ where | |||
| Ok(Arc::new(byte_array_builder.finish())) | |||
| } | |||
|
|
|||
| trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized { | |||
There was a problem hiding this comment.
We would now have this in arrow-string and arrow-cast. Perhaps this would be best moved to arrow-array alongside ArrayAccessor ?
There was a problem hiding this comment.
@Omega359 Thanks so much for reviewing.
We would now have this in arrow-string and arrow-cast. Perhaps this would be best moved to arrow-array alongside ArrayAccessor ?
Makes sense to me 👍
Signed-off-by: Tai Le Manh <[email protected]>
alamb
changed the title
StringViewArray to DecimalArray
alamb
reviewed
Nov 15, 2024
| @@ -570,6 +572,40 @@ pub trait ArrayAccessor: Array { | |||
| unsafe fn value_unchecked(&self, index: usize) -> Self::Item; | |||
| } | |||
|
|
|||
| /// A trait for Arrow String Arrays, currently three types are supported: | |||
There was a problem hiding this comment.
This is nice to start making public -- we use it in DataFusion a bit as well, so starting to consolidate on a single implementation will be good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6715.
Rationale for this change
What changes are included in this PR?
Utf8View) to numeric(Int/Float/Decimal).Are there any user-facing changes?
No.