Return error rather than panic when too many row groups are written #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wrote the test trying to track down #6591...if we don't want it then this can just be closed. |
tustvold
approved these changes
Oct 28, 2024
alamb
reviewed
Oct 29, 2024
| assert_eq!(i, 0x8000); | ||
| assert_eq!( | ||
| e.to_string(), | ||
| "Parquet error: Parquet does not support more than 32767 row groups per file (currently: 32768)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6591.
Rationale for this change
Does not panic in the unlikely event that the row group ordinal is negative when writing bloom filters.
What changes are included in this PR?
Replace
expectwithmap_err, also adds test for changes from #6378.Are there any user-facing changes?
No, since the panic should no longer be possible to trigger.