Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParquetObjectReader::with_runtime (#6248) #6249

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #6248

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 14, 2024
@alamb
Copy link
Contributor

alamb commented Sep 18, 2024

I am depressed about the large review backlog in this crate. We are looking for more help from the community reviewing PRs -- see #6418 for more

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold -- the idea here looks great. I think what we need to do now is to add some sort of test (maybe a doc example or something) showing how to use this and it would be good to go

@wiedld
Copy link
Contributor

wiedld commented Sep 27, 2024

Thank you @tustvold -- the idea here looks great. I think what we need to do now is to add some sort of test (maybe a doc example or something) showing how to use this and it would be good to go

@tustvold -- do you mind if I take this over, adding docs & tests?

@alamb alamb marked this pull request as draft October 1, 2024 19:45
@alamb
Copy link
Contributor

alamb commented Oct 1, 2024

Converting to draft as @wiedld works on the tests

@alamb
Copy link
Contributor

alamb commented Oct 9, 2024

Closing and @wiedld will reopen when she has tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ParquetObjectReader::with_runtime
3 participants