Fix array equal check #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 82.47% 82.47% -0.01%
==========================================
Files 167 167
Lines 46144 46198 +54
==========================================
+ Hits 38059 38100 +41
- Misses 8085 8098 +13
Continue to review full report at Codecov.
|
jorgecarleitao
approved these changes
Jul 20, 2021
alamb
approved these changes
Jul 20, 2021
| @@ -2347,7 +2347,7 @@ mod tests { | |||
| nulls_first: true, | |||
| }), | |||
| Some(3), | |||
| vec![None, None, Some(vec![Some(2)])], | |||
| vec![None, None, Some(vec![Some(1)])], | |||
|
FYI @nevi-me and @bjchambers |
|
Thanks again @waynexia |
alamb
pushed a commit
that referenced
this pull request
Jul 20, 2021
* pin this bug down & fix Signed-off-by: Ruihang Xia <[email protected]> * tidy Signed-off-by: Ruihang Xia <[email protected]> * add some test cases Signed-off-by: Ruihang Xia <[email protected]>
alamb
added a commit
that referenced
this pull request
Jul 21, 2021
* pin this bug down & fix Signed-off-by: Ruihang Xia <[email protected]> * tidy Signed-off-by: Ruihang Xia <[email protected]> * add some test cases Signed-off-by: Ruihang Xia <[email protected]> Co-authored-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #570.
What changes are included in this PR?
This PR fixes the problem mentioned in #570 and adds some negative test cases.
Are there any user-facing changes?
No.