Implement MultiPartStore for InMemory #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
multipart-memory
branch
2 times, most recently
from
5434271
to
5492390
Compare
alamb
approved these changes
Mar 12, 2024
|
|
||
| #[derive(Debug, Default, Clone)] | ||
| struct PartStorage { | ||
| parts: Vec<Option<Bytes>>, |
There was a problem hiding this comment.
is it worth nothing in a doc comment somewhere that unfinished multi part uploads are never cleaned up?
There was a problem hiding this comment.
I think this is implicit in the contract of MultipartStore
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #5458.
Rationale for this change
Makes it easier to use InMemory to test functionality making use of
MultiPartStoreWhat changes are included in this PR?
Are there any user-facing changes?