Add GetOptions::head #4931
Merged
Add GetOptions::head #4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Oct 13, 2023
| }); | ||
|
|
||
| let location = Path::from(filename); | ||
| integration.head(&location).await.unwrap(); |
There was a problem hiding this comment.
This has to be moved after the spawn_blocking as it now will open the file, which will block until the writer opens it, I don't see this being an issue as the behaviour of a head request on a file that gets mutated behind the scenes are not exactly very well defined anyway 😅
tustvold
commented
Oct 13, 2023
| // Need to open read and write side in parallel | ||
| let spawned = tokio::task::spawn_blocking(|| { | ||
| OpenOptions::new().write(true).open(path).unwrap(); |
There was a problem hiding this comment.
This semicolon fixes a subtle bug, where the writer is immediately dropped which then causes subsequent opens to block. I'm actually somewhat surprised it has worked semi-reliably so far. By returning the File, we defer destruction until after we're done with the file
viirya
approved these changes
Oct 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #4925
Relates to #4525
Rationale for this change
Adds
GetOptions::head. This achieves a couple of goals:ObjectStore::headWhat changes are included in this PR?
Are there any user-facing changes?