fix: entries field is non-nullable #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
added
arrow
viirya
reviewed
Sep 10, 2023
| @@ -1487,7 +1487,7 @@ mod tests { | |||
| let keys_field = Arc::new(Field::new_dict( | |||
| "keys", | |||
| DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)), | |||
| true, | |||
| true, // It is technically not legal for this field to be null. | |||
There was a problem hiding this comment.
The test itself has null values in the test case. Perhaps I should modify the test case?
There was a problem hiding this comment.
Oh, I got what you mean. Okay to keep it as is.
viirya
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4807.
Rationale for this change
The "entries" field shouldn't be nullable:
https://github.com/apache/arrow/blob/c4b01c60fba85bbfc3a1b1510e179153c0f79515/format/Schema.fbs#L124
Elsewhere, we have this as false already:
https://github.com/apache/arrow-rs/blob/master/arrow-schema/src/field.rs#L230
The inconsistency on this causes schema mismatch issues, such as those documented in:
delta-io/delta-rs#1619
What changes are included in this PR?
Changes all functions that construct the
"entries"field to be non-nullable.Are there any user-facing changes?
Yes, this will change the type output by the
MapType::new_from_strings()andcanonicalize_schema()functions.