Convince the compiler to auto-vectorize the range check in parquet DictionaryBuffer #4453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I noticed an unexpected hotspot when profiling parquet benchmarks for dictionary encoded arrays. The range checks that verify keys are in bounds take a relatively large amount of time. There was already a comment suggesting to use simd instructions, and in my opinion the compiler should have been able to auto-vectorize the existing code, but it took some experimentation to get the compiler generate more efficient code.
Benchmark results compared to master branch on my laptop
(using rust 1.70, there was no change in generated code in earlier versions)
What changes are included in this PR?
basically a one-line change
Are there any user-facing changes?
no