Arrow Arithmetic: Subtract timestamps #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some thoughts:
|
mr-brobot
changed the title
tustvold
reviewed
May 18, 2023
| @@ -4649,4 +4731,144 @@ mod tests { | |||
| ]); | |||
| assert_eq!(&expected, result); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_timestamp_second_subtract_timestamp() { | |||
There was a problem hiding this comment.
I wonder if we could extract a generic function typed on the timestamp and duration types, this would avoid the duplication?
I think this is fine, we don't provide arithmetic between different integer precisions either - I think the responsibility is on the query engine to add type coercion logic where necessary 👍 |
tustvold
reviewed
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3964
Rationale for this change
See #3964
What changes are included in this PR?
subtract_dynandsubtract_dyn_checkednow support subtracting timestamps of the same resolution. The result is a duration of the same resolution as the timestamp operands.Are there any user-facing changes?
Expanded timestamp support for
subtract_dynandsubtract_dyn_checked.