-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old JSON Reader and Decoder (#3610) #4052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
Changes to the arrow crate
parquet
Changes to the parquet crate
labels
Apr 11, 2023
tustvold
commented
Apr 11, 2023
use serde_json::Value; | ||
use arrow_schema::{ArrowError, DataType, Field, Fields, Schema}; | ||
|
||
#[derive(Debug, Clone)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just moved from reader.rs
tustvold
force-pushed
the
remove-json-reader
branch
from
April 11, 2023 13:37
e5497e7
to
068c95c
Compare
crepererum
approved these changes
Apr 11, 2023
I'm working on porting more of the tests across |
tustvold
commented
Apr 11, 2023
.collect(); | ||
|
||
let batch = RecordBatch::try_new(self.schema.clone(), columns)?; | ||
let batch = RecordBatch::from(StructArray::from(decoded)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix for #4053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-change
Changes to the arrow API
arrow
Changes to the arrow crate
parquet
Changes to the parquet crate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3610
Closes #4053
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
This removes a deprecated API