Add offsets accessors to variable length arrays (#3879) #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 11, 2023
| @@ -67,6 +67,18 @@ impl<T: ByteArrayType> GenericByteArray<T> { | |||
| offsets[i + 1] - offsets[i] | |||
| } | |||
|
|
|||
| /// Returns a reference to the offsets of this array | |||
There was a problem hiding this comment.
I think it might help to note in the docstrings:
- How this is different than
value_offsets(other than the signature) - Which is preferred (it sounds from this PR's description that
offsetsis preferred, but that is not obvious from the code as it is written)
The same applies to values and value_data
viirya
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3879
Rationale for this change
This provides access to the typed buffer abstractions, which allows for destructing of arrays. I opted to add new functions, instead of changing the return types of
value_dataandvalue_offsetsto reduce code churn, and also because the value prefix is a tad redundant. I expect we may eventually deprecate and remove the old methods.What changes are included in this PR?
Are there any user-facing changes?