Restrict DictionaryArray to ArrowDictionaryKeyType #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
approved these changes
Mar 7, 2023
tustvold
commented
Mar 7, 2023
| @@ -955,14 +955,6 @@ mod tests { | |||
| DictionaryArray::<Int32Type>::try_new(&keys, &values).unwrap(); | |||
| } | |||
|
|
|||
| #[test] | |||
| #[should_panic(expected = "Dictionary key type must be integer, but was Float32")] | |||
| fn test_try_wrong_dictionary_key_type() { | |||
There was a problem hiding this comment.
This now results in a compilation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1799
Rationale for this change
DictionaryArray should only be constructible for valid dictionary indexes, this is strictly enforced by the move to structured ArrayData, and so we need to enforce this strictly for the array type also.
What changes are included in this PR?
A few call-sites, including the DictionaryArray definition weren't restricted to
ArrowDictionaryKeyType, they now areAre there any user-facing changes?