Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayData Enumeration for Remaining Layouts #3769

Merged
merged 11 commits into from
Mar 1, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arrow-data/src/data/bytes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ impl<O: BytesOffset, B: Bytes> BytesArrayData<O, B> {

/// Returns the offsets
#[inline]
pub fn value_offsets(&self) -> &[O] {
pub fn offsets(&self) -> &[O] {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value_ prefix is redundant

&self.offsets
}

Expand Down
170 changes: 170 additions & 0 deletions arrow-data/src/data/dictionary.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use crate::data::types::DictionaryKeyType;
use crate::ArrayData;
use arrow_buffer::buffer::{NullBuffer, ScalarBuffer};
use arrow_buffer::ArrowNativeType;
use arrow_schema::DataType;

mod private {
use super::*;

pub trait DictionaryKeySealed {
/// Downcast [`ArrayDataDictionary`] to `[DictionaryArrayData`]
fn downcast_ref(data: &ArrayDataDictionary) -> Option<&DictionaryArrayData<Self>>
where
Self: DictionaryKey;

/// Downcast [`ArrayDataDictionary`] to `[DictionaryArrayData`]
fn downcast(data: ArrayDataDictionary) -> Option<DictionaryArrayData<Self>>
where
Self: DictionaryKey;

/// Cast [`DictionaryArrayData`] to [`ArrayDataDictionary`]
fn upcast(v: DictionaryArrayData<Self>) -> ArrayDataDictionary
where
Self: DictionaryKey;
}
}

/// Types of offset used by variable length byte arrays
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems wrong due to copying?

pub trait DictionaryKey: private::DictionaryKeySealed + ArrowNativeType {
const TYPE: DictionaryKeyType;
}

pub enum ArrayDataDictionary {
Int8(DictionaryArrayData<i8>),
Int16(DictionaryArrayData<i16>),
Int32(DictionaryArrayData<i32>),
Int64(DictionaryArrayData<i64>),
UInt8(DictionaryArrayData<u8>),
UInt16(DictionaryArrayData<u16>),
UInt32(DictionaryArrayData<u32>),
UInt64(DictionaryArrayData<u64>),
}

macro_rules! dictionary {
($t:ty,$v:ident) => {
impl DictionaryKey for $t {
const TYPE: DictionaryKeyType = DictionaryKeyType::$v;
}
impl private::DictionaryKeySealed for $t {
fn downcast_ref(
data: &ArrayDataDictionary,
) -> Option<&DictionaryArrayData<Self>> {
match data {
ArrayDataDictionary::$v(v) => Some(v),
_ => None,
}
}

fn downcast(data: ArrayDataDictionary) -> Option<DictionaryArrayData<Self>> {
match data {
ArrayDataDictionary::$v(v) => Some(v),
_ => None,
}
}

fn upcast(v: DictionaryArrayData<Self>) -> ArrayDataDictionary {
ArrayDataDictionary::$v(v)
}
}
};
}

dictionary!(i8, Int8);
dictionary!(i16, Int16);
dictionary!(i32, Int32);
dictionary!(i64, Int64);
dictionary!(u8, UInt8);
dictionary!(u16, UInt16);
dictionary!(u32, UInt32);
dictionary!(u64, UInt64);

impl ArrayDataDictionary {
/// Downcast this [`ArrayDataDictionary`] to the corresponding [`DictionaryArrayData`]
pub fn downcast_ref<K: DictionaryKey>(&self) -> Option<&DictionaryArrayData<K>> {
K::downcast_ref(self)
}

/// Downcast this [`ArrayDataDictionary`] to the corresponding [`DictionaryArrayData`]
pub fn downcast<K: DictionaryKey>(self) -> Option<DictionaryArrayData<K>> {
K::downcast(self)
}
}

impl<K: DictionaryKey> From<DictionaryArrayData<K>> for ArrayDataDictionary {
fn from(value: DictionaryArrayData<K>) -> Self {
K::upcast(value)
}
}

pub struct DictionaryArrayData<K: DictionaryKey> {
data_type: DataType,
nulls: Option<NullBuffer>,
keys: ScalarBuffer<K>,
child: Box<ArrayData>,
}

impl<K: DictionaryKey> DictionaryArrayData<K> {
/// Create a new [`DictionaryArrayData`]
///
/// # Safety
///
/// - `data_type` must be valid for this layout
/// - child must have a type matching `data_type`
/// - all values in `keys` must be `0 < v < child.len()` or be a null according to `nulls`
/// - `nulls` must have the same length as `child`
pub unsafe fn new_unchecked(
data_type: DataType,
keys: ScalarBuffer<K>,
nulls: Option<NullBuffer>,
child: ArrayData,
) -> Self {
Self {
data_type,
nulls,
keys,
child: Box::new(child),
}
}

/// Returns the null buffer if any
#[inline]
pub fn nulls(&self) -> Option<&NullBuffer> {
self.nulls.as_ref()
}

/// Returns the keys
#[inline]
pub fn keys(&self) -> &[K] {
&self.keys
}

/// Returns the child data
#[inline]
pub fn child(&self) -> &ArrayData {
self.child.as_ref()
}

/// Returns the data type of this array
#[inline]
pub fn data_type(&self) -> &DataType {
&self.data_type
}
}
192 changes: 192 additions & 0 deletions arrow-data/src/data/list.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use crate::data::types::OffsetType;
use crate::ArrayData;
use arrow_buffer::buffer::{NullBuffer, ScalarBuffer};
use arrow_buffer::{ArrowNativeType, Buffer};
use arrow_schema::DataType;

mod private {
use super::*;

pub trait ListOffsetSealed {
/// Downcast [`ArrayDataList`] to `[ListArrayData`]
fn downcast_ref(data: &ArrayDataList) -> Option<&ListArrayData<Self>>
where
Self: ListOffset;

/// Downcast [`ArrayDataList`] to `[ListArrayData`]
fn downcast(data: ArrayDataList) -> Option<ListArrayData<Self>>
where
Self: ListOffset;

/// Cast [`ListArrayData`] to [`ArrayDataList`]
fn upcast(v: ListArrayData<Self>) -> ArrayDataList
where
Self: ListOffset;
}
}

/// Types of offset used by variable length byte arrays
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

pub trait ListOffset: private::ListOffsetSealed + ArrowNativeType {
const TYPE: OffsetType;
}

impl ListOffset for i32 {
const TYPE: OffsetType = OffsetType::Int32;
}

impl private::ListOffsetSealed for i32 {
fn downcast_ref(data: &ArrayDataList) -> Option<&ListArrayData<Self>>
where
Self: ListOffset,
{
match data {
ArrayDataList::Small(v) => Some(v),
ArrayDataList::Large(_) => None,
}
}

fn downcast(data: ArrayDataList) -> Option<ListArrayData<Self>>
where
Self: ListOffset,
{
match data {
ArrayDataList::Small(v) => Some(v),
ArrayDataList::Large(_) => None,
}
}

fn upcast(v: ListArrayData<Self>) -> ArrayDataList
where
Self: ListOffset,
{
ArrayDataList::Small(v)
}
}

impl ListOffset for i64 {
const TYPE: OffsetType = OffsetType::Int64;
}

impl private::ListOffsetSealed for i64 {
fn downcast_ref(data: &ArrayDataList) -> Option<&ListArrayData<Self>>
where
Self: ListOffset,
{
match data {
ArrayDataList::Small(_) => None,
ArrayDataList::Large(v) => Some(v),
}
}

fn downcast(data: ArrayDataList) -> Option<ListArrayData<Self>>
where
Self: ListOffset,
{
match data {
ArrayDataList::Small(_) => None,
ArrayDataList::Large(v) => Some(v),
}
}

fn upcast(v: ListArrayData<Self>) -> ArrayDataList
where
Self: ListOffset,
{
ArrayDataList::Large(v)
}
}

/// ArrayData for variable length list arrays
pub enum ArrayDataList {
Small(ListArrayData<i32>),
Large(ListArrayData<i64>),
}

impl ArrayDataList {
/// Downcast this [`ArrayDataList`] to the corresponding [`ListArrayData`]
pub fn downcast_ref<O: ListOffset>(&self) -> Option<&ListArrayData<O>> {
O::downcast_ref(self)
}

/// Downcast this [`ArrayDataList`] to the corresponding [`ListArrayData`]
pub fn downcast<O: ListOffset>(self) -> Option<ListArrayData<O>> {
O::downcast(self)
}
}

impl<O: ListOffset> From<ListArrayData<O>> for ArrayDataList {
fn from(value: ListArrayData<O>) -> Self {
O::upcast(value)
}
}

pub struct ListArrayData<O: ListOffset> {
data_type: DataType,
nulls: Option<NullBuffer>,
offsets: ScalarBuffer<O>,
child: Box<ArrayData>,
}

impl<O: ListOffset> ListArrayData<O> {
/// Create a new [`ListArrayData`]
///
/// # Safety
///
/// - Each consecutive window of `offsets` must identify a valid slice of `child`
/// - `nulls.len() == offsets.len() + 1`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - `nulls.len() == offsets.len() + 1`
/// - `nulls.len() == offsets.len() - 1`

?

/// - `data_type` must be valid for this layout
pub unsafe fn new_unchecked(
data_type: DataType,
offsets: ScalarBuffer<O>,
nulls: Option<NullBuffer>,
child: ArrayData,
) -> Self {
Self {
data_type,
nulls,
offsets,
child: Box::new(child),
}
}

/// Returns the null buffer if any
#[inline]
pub fn nulls(&self) -> Option<&NullBuffer> {
self.nulls.as_ref()
}

/// Returns the offsets
#[inline]
pub fn offsets(&self) -> &[O] {
&self.offsets
}

/// Returns the child data
#[inline]
pub fn child(&self) -> &ArrayData {
self.child.as_ref()
}

/// Returns the data type of this array
#[inline]
pub fn data_type(&self) -> &DataType {
&self.data_type
}
}
6 changes: 6 additions & 0 deletions arrow-data/src/data/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,14 @@ use crate::equal;
#[allow(unused)] // Private until ready (#1176)
mod bytes;
#[allow(unused)] // Private until ready (#1176)
mod dictionary;
#[allow(unused)] // Private until ready (#1176)
mod primitive;
#[allow(unused)] // Private until ready (#1176)
mod r#struct;
#[allow(unused)] // Private until ready (#1176)
mod list;
#[allow(unused)] // Private until ready (#1176)
mod types;

#[inline]
Expand Down
Loading