Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer 2020-03-19 00:00:00 as timestamp not Date64 in CSV (#3744) #3746

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Infer 2020-03-19 00:00:00 as timestamp not Date64 in CSV (#3744) #3746

merged 2 commits into from
Feb 23, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Feb 22, 2023 •
edited
Loading

Which issue does this PR close?

Closes #3744

Rationale for this change

As per https://lists.apache.org/thread/q036r1q3cw5ysn3zkpvljx3s9ho18419 Date64 should not be used for time data.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 22, 2023
@tustvold tustvold marked this pull request as ready for review February 22, 2023 20:01
tustvold
tustvold commented Feb 22, 2023
View reviewed changes
arrow-csv/src/reader/mod.rs
} else {
DataType::Utf8
#[derive(Default, Copy, Clone)]
struct InferredDataType {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should be significantly faster as an added bonus

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tustvold tustvold requested a review from viirya February 22, 2023 21:48
@tustvold tustvold merged commit e753dea into apache:master Feb 23, 2023
@tustvold tustvold added the api-change Changes to the arrow API label Feb 23, 2023
@ursabot
Copy link

ursabot commented Feb 23, 2023

Benchmark runs are scheduled for baseline = 6bf0aab and contender = e753dea. e753dea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold mentioned this pull request Feb 24, 2023
Closed
This was referenced Apr 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV reader infers Date64 type for fields like "2020-03-19 00:00:00" that it can't parse to Date64
3 participants
@tustvold @ursabot @viirya