Disable MIRI check until it runs cleanly on CI #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
May 26, 2021
nevi-me
approved these changes
May 26, 2021
|
I think @roee88 has found the root cause: #345 (comment) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #345 (but doesn't fix the underlying issue)
Rationale for this change
The MIRI checks enabled in #323 have been failing frequently with false positives on PRs and master. Until they run cleanly and only fail when there are actual problems, running these CI checks on all PRs is slowing everyone down and causing confusion,
What changes are included in this PR?
I disabled the whole thing this time, whereas prior to #323 they "ran" but the results were not checked. That seems like a waste of CPU time / github actions credits to me.
Are there any user-facing changes?
Hopefully contributors' PRs will stop getting failing checks