Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests for StringArray and LargeStringArray. #330

Merged
merged 1 commit into from
May 20, 2021

Conversation

novemberkilo
Copy link
Contributor

@novemberkilo novemberkilo commented May 20, 2021

Which issue does this PR close?

Re #301

What changes are included in this PR?

Additional doctests for StringArray and LargeStringArray

Are there any user-facing changes?

No

@novemberkilo
Copy link
Contributor Author

@alamb putting this up for quick feedback. Please let me know if this is the right level of additional documentation, or if we should have more. Also, happy to include similar for more Array types -- or to tackle those in separate PRs.

@jorgecarleitao jorgecarleitao added the documentation Improvements or additions to documentation label May 20, 2021
@jorgecarleitao jorgecarleitao changed the title MINOR: Doctests for StringArray and LargeStringArray. Doctests for StringArray and LargeStringArray. May 20, 2021
@jorgecarleitao jorgecarleitao removed the documentation Improvements or additions to documentation label May 20, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @novemberkilo I think this will be super helpful for users to quickly find how to create StringArray 👍

@Dandandan Dandandan merged commit e18b356 into apache:master May 20, 2021
@Dandandan
Copy link
Contributor

Thanks @novemberkilo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants