Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline PrimitiveArray::value #329

Merged
merged 1 commit into from
May 20, 2021

Conversation

ritchie46
Copy link
Contributor

This PR add #[inline] tags to PrimitiveArray::value and PrimitiveArray::value_unchecked, both do simple ptr arithmetic and may benefit from inlining.

#328

@codecov-commenter
Copy link

Codecov Report

Merging #329 (be9ccdb) into master (7f37a7f) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head be9ccdb differs from pull request most recent head fda12d3. Consider uploading reports for the commit fda12d3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   82.52%   82.52%   -0.01%     
==========================================
  Files         162      162              
  Lines       44021    44021              
==========================================
- Hits        36329    36328       -1     
- Misses       7692     7693       +1     
Impacted Files Coverage Δ
arrow/src/array/array_primitive.rs 92.93% <ø> (ø)
arrow/src/array/transform/boolean.rs 76.92% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f37a7f...fda12d3. Read the comment docs.

@Dandandan Dandandan merged commit 087cf17 into apache:master May 20, 2021
@Dandandan
Copy link
Contributor

Thanks @ritchie46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants