-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support casting from Decimal256 to float types #3267
Conversation
df59556
to
89a5dd9
Compare
|
||
// loss the precision: convert decimal to f32、f64 | ||
// f32 | ||
// 112345678_f32 and 112345679_f32 are same, so the 112345679_f32 will lose precision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
None, | ||
Some(5.25_f32), | ||
Some(1_123_456.7_f32), | ||
Some(1_123_456.7_f32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks @liukun4515 |
Benchmark runs are scheduled for baseline = 1640fd1 and contender = 06e1111. 06e1111 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3266.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?