-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests which require chrono-tz feature from arrow-cast
to arrow
#3222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we instead move these to be integration tests in arrow-rs. Otherwise the inconsistent feature flags will result lots of recompilation when switching crates and targets?
Okay. |
arrow-cast
cratearrow-cast
crate to arrow
arrow-cast
crate to arrow
arrow-cast
to arrow
@@ -3614,7 +3616,6 @@ mod tests { | |||
} | |||
|
|||
#[test] | |||
#[cfg(not(feature = "force_validate"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the tests which depend on not "force_validate", I just removed the effectless cfg
because that feature doesn't exist in the crate.
arrow-cast
to arrow
arrow-cast
to arrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit concerning feature compilation
Strangely I can't see this in the CI output, but running |
I see it in the CI output at https://github.com/apache/arrow-rs/actions/runs/3586065699/jobs/6034811204:
|
Aah I was using the browser search not the one built into the UI 👍 |
Benchmark runs are scheduled for baseline = 6bd559f and contender = 9538c26. 9538c26 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3219.
Closes #3220.
Closes #3221.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?