Row decode cleanups #3180
Row decode cleanups #3180
Conversation
| @@ -266,60 +267,42 @@ pub fn decode_bool(rows: &mut [&[u8]], options: SortOptions) -> BooleanArray { | |||
| unsafe { BooleanArray::from(builder.build_unchecked()) } | |||
| } | |||
|
|
|||
| fn decode_nulls(rows: &[&[u8]]) -> (usize, Buffer) { | |||
There was a problem hiding this comment.
Handling the null mask separately has no discernible impact on performance, it is possible it might actually improve it marginally, it reduces code complexity significantly, and will help reuse this logic for the fixed length binary array (PR to follow)
|
Benchmark runs are scheduled for baseline = 187bf61 and contender = d74c48e. d74c48e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
Exploit fact decimal is now a primitive array, and we now have more sophisticated macros, to cleanup some code.
I have run the benchmarks and confirmed this does not impact performance
What changes are included in this PR?
Are there any user-facing changes?