Add downcast_array (#2901) #3117
Conversation
| where | ||
| T: From<ArrayData>, | ||
| { | ||
| T::from(array.data().clone()) |
There was a problem hiding this comment.
There may be some mechanism to avoid this clone, if/when we work this out this can be optimised. In practice, this clone should be irrelevant, as it all the underlying buffers are reference counted
There was a problem hiding this comment.
Will this clone make us unable to Arc::try_unwrap later?
There was a problem hiding this comment.
Provided the source Array is dropped first, and there are no other references to the underlying Buffer, e.g. as a result of slicing the array, it will work.
Edit: There isn't really a way to avoid this, even approaches using AsDynAny, etc... will have the same complication
There was a problem hiding this comment.
Okay. Let's merge this so I can play with it in #3115.
|
Benchmark runs are scheduled for baseline = b0b5d8b and contender = 5c2801d. 5c2801d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
👌 |
Which issue does this PR close?
Closes #2901
Rationale for this change
Make this technique more discoverable
What changes are included in this PR?
Are there any user-facing changes?