Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make intersect_row_selections a member function #3084

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Make intersect_row_selections a member function #3084

merged 1 commit into from
Nov 11, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Builds on #3047

What changes are included in this PR?

Are there any user-facing changes?

No changes to released APIs, although depending on timings this may change

@tustvold tustvold requested review from alamb and Ted-Jiang November 10, 2022 21:38
@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 10, 2022
tustvold
tustvold commented Nov 10, 2022
View reviewed changes
parquet/src/arrow/arrow_reader/selection.rs
// other: NYNNNNNNY
//
// returned: NNNNNNNNYYNYN
pub fn intersect_row_selections(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also keep this public, but I don't see a reason to do so

@tustvold tustvold changed the title Make RowSelection::intersection a member function Make intersect_row_selections a member function Nov 10, 2022
@tustvold tustvold force-pushed the add-row-selector-intersection branch from f5faf5d to f7c4ab2 Compare November 10, 2022 21:45
viirya
viirya approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@alamb alamb merged commit 5226258 into apache:master Nov 11, 2022
@ursabot
Copy link

ursabot commented Nov 11, 2022

Benchmark runs are scheduled for baseline = 885a361 and contender = 5226258. 5226258 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@viirya viirya viirya approved these changes

@Ted-Jiang Ted-Jiang Awaiting requested review from Ted-Jiang

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tustvold @ursabot @viirya @alamb