Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null_count computation in binary #3062

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix null_count computation in binary #3062

merged 1 commit into from
Nov 9, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 9, 2022

Which issue does this PR close?

Closes #3061.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 9, 2022
jhorstmann
jhorstmann reviewed Nov 9, 2022
View reviewed changes
arrow/src/compute/kernels/arithmetic.rs

let arg1: Int32Array = ArrayDataBuilder::new(DataType::Int32)
.len(13)
.null_count(13)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the test skip setting the null count explicitly and instead let the ArrayDataBuilder calculate it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the parameter is actually ignored and build always recalculates it. Only build_unchecked would use it.

@jhorstmann
Copy link
Contributor

Looks good to me 👍

tustvold
tustvold approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick check that these are the only two places where we are using Buffer::count_set_bits in an incorrect way as this.

@tustvold
Copy link
Contributor

tustvold commented Nov 9, 2022

I've also filed #3067 to remove this particular footgun

@tustvold tustvold merged commit 6057cf7 into apache:master Nov 9, 2022
@ursabot
Copy link

ursabot commented Nov 9, 2022

Benchmark runs are scheduled for baseline = 6b3a0a2 and contender = 6057cf7. 6057cf7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

This was referenced Nov 11, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhorstmann jhorstmann jhorstmann left review comments

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binary operator produces incorrect result on arrays with resized null buffer
4 participants
@viirya @jhorstmann @tustvold @ursabot