Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster f64 equality #3060

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Faster f64 equality #3060

merged 1 commit into from
Nov 9, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Nov 9, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

LLVM isn't smart enough to work out that this is just a bitwise equality, so give it a hand - https://rust.godbolt.org/z/347nWGxoW

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold requested a review from viirya November 9, 2022 05:35
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 9, 2022
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this works for f64::NAN too.

@tustvold tustvold merged commit 6b3a0a2 into apache:master Nov 9, 2022
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the same apply for is_ne?

@ursabot
Copy link

ursabot commented Nov 9, 2022

Benchmark runs are scheduled for baseline = 8d75101 and contender = 6b3a0a2. 6b3a0a2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@mbrobbel
Copy link
Contributor

@tustvold
Copy link
Contributor Author

@mbrobbel This crate follows the totalOrder predicate as defined in the IEEE 754 (2008 revision) floating point standard, which is different from the default PartialOrd and PartialEq implementations provided by Rust for floating point numbers. Instead using https://doc.rust-lang.org/std/primitive.f32.html#method.total_cmp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants