Replace hour_generic with hour_dyn #3006
Conversation
| } | ||
|
|
||
| /// Extracts the hours of a given temporal array as an array of integers within | ||
| /// the range of [0, 23]. | ||
| pub fn hour_generic<T, A: ArrayAccessor<Item = T::Native>>(array: A) -> Result<Int32Array> |
There was a problem hiding this comment.
I remove it directly. Let me know if you think it is better to deprecate it first.
| /// Extracts the hours of a given array as an array of integers within | ||
| /// the range of [0, 23]. If the given array isn't temporal primitive or dictionary array, | ||
| /// an `Err` will be returned. | ||
| pub fn hour_dyn(array: &dyn Array) -> Result<ArrayRef> { |
There was a problem hiding this comment.
I presume the body of this will be extracted into a generic function as part of converting the other functions?
There was a problem hiding this comment.
Yea, I will try to extract this when I work on other functions.
|
Benchmark runs are scheduled for baseline = b4365eb and contender = 8400b09. 8400b09 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3005.
Part of #3004.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?