-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and automate new release process #299
Conversation
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 82.52% 82.52% -0.01%
==========================================
Files 162 162
Lines 44007 44007
==========================================
- Hits 36316 36315 -1
- Misses 7691 7692 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG so far. Thanks a lot, @alamb !
cc @kszucs |
This is ready for review at your convenience @jorgecarleitao / @andygrove |
dev/release/README.md
Outdated
should) then the crate can be published with the following command: | ||
|
||
```shell | ||
cargo publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work unfortunately. We have to manually go to each crate directory and run cargo publish
for each one, in order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -- I added the following (and I will test / update the docs again after I try with the next arrow release)
(cd arrow && cargo publish)
(cd arrow_flight && cargo publish)
(cd parquet && cargo publish)
(cd parquet_derive && cargo publish)
dev/release/README.md
Outdated
If the Cargo.toml does not have the correct version then it will be necessary | ||
to modify it manually. Since there is now a modified file locally that is not | ||
committed to GitHub it will be necessary to use the following command. | ||
|
||
```shell | ||
cargo publish --allow-dirty | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this section now. This was here because we had issues with the scripts updating the version numbers early on. We should check that the version numbers are correct when voting on a release candidate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove
I plan to merge this PR in and then iterate on the docs and scripts as we do some more releases. I am happy to make any other changes as part of a subsequent PR |
Re #292
This PR contains documentation and scripts for the arrow-rs release process. It will probably evolve as we do this a few more times.
Rationale for this change
Make release process simple and repeatable
What changes are included in this PR?
Are there any user-facing changes?
Not directly