Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move concat kernel to arrow-select (#2594) #2976

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #2594

Rationale for this change

I think this is the most logical place for this kernel to live, as it is effectively a specialized version of interleave.

What changes are included in this PR?

Moves the concat kernel into arrow-select

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 29, 2022
@paddyhoran paddyhoran changed the title More concat kernel to arrow-select (#2594) Move concat kernel to arrow-select (#2594) Oct 29, 2022
@tustvold tustvold merged commit 999a6ae into apache:master Oct 29, 2022
@ursabot
Copy link

ursabot commented Oct 29, 2022

Benchmark runs are scheduled for baseline = 37f16b5 and contender = 999a6ae. 999a6ae is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants