Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup orphaned doc comments (#2935) #2938

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Cleanup orphaned doc comments (#2935) #2938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions parquet/src/file/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,6 @@ impl<W: Write> SerializedFileWriter<W> {
}

/// Closes and finalises file writer, returning the file metadata.
///
/// All row groups must be appended before this method is called.
/// No writes are allowed after this point.
///
/// Can be called multiple times. It is up to implementation to either result in
/// no-op, or return an `Err` for subsequent calls.
pub fn close(mut self) -> Result<parquet::FileMetaData> {
self.assert_previous_writer_closed()?;
let metadata = self.write_metadata()?;
Expand Down Expand Up @@ -431,10 +425,6 @@ impl<'a, W: Write> SerializedRowGroupWriter<'a, W> {
}

/// Closes this row group writer and returns row group metadata.
/// After calling this method row group writer must not be used.
///
/// Can be called multiple times. In subsequent calls will result in no-op and return
/// already created row group metadata.
pub fn close(mut self) -> Result<RowGroupMetaDataPtr> {
if self.row_group_metadata.is_none() {
self.assert_previous_writer_closed()?;
Expand Down