Simplify ListArray::from_iter_primitive #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Oct 16, 2022
| @@ -157,47 +157,26 @@ impl<OffsetSize: OffsetSizeTrait> GenericListArray<OffsetSize> { | |||
| pub fn from_iter_primitive<T, P, I>(iter: I) -> Self | |||
| where | |||
| T: ArrowPrimitiveType, | |||
| P: AsRef<[Option<<T as ArrowPrimitiveType>::Native>]> | |||
There was a problem hiding this comment.
This AsRef constraint is rather constraining, it is good to see it gone
alamb
reviewed
Oct 18, 2022
alamb
approved these changes
Oct 18, 2022
alamb
reviewed
Oct 18, 2022
| Self::from(array_data) | ||
| builder.append(true); | ||
| } | ||
| None => builder.append(false), |
There was a problem hiding this comment.
There was a problem hiding this comment.
No, that was only needed because nulls in a fixed size list take up the same amount of space as non-null values
Not sure, as it is only removing a trait bound not adding a new one. So it should be backwards compatible
Not that I could find, I'm not sure that this method is used anywhere outside of tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Drive by cleanup
What changes are included in this PR?
Are there any user-facing changes?