Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually bump development version #288

Merged
merged 1 commit into from
May 15, 2021
Merged

Conversation

nevi-me
Copy link
Contributor

@nevi-me nevi-me commented May 13, 2021

Which issue does this PR close?

Closes #271 .

Rationale for this change

We haven't bumped versions after arrow 4.0.0 was released.

What changes are included in this PR?

Bumps versions

Are there any user-facing changes?

None

@alamb
Copy link
Contributor

alamb commented May 14, 2021

The integration test failure seems unrelated (though maybe not?) -- https://github.com/apache/arrow-rs/pull/288/checks?check_run_id=2574974207

I retriggered it to see if it passes on a second time

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests all pass

@jorgecarleitao
Copy link
Member

@alamb the integration tests were failing about 8h ago, but all good now afaik. Someone fixed this in apache/arrow :)

@alamb
Copy link
Contributor

alamb commented May 14, 2021

And the tests are now all 🎉

@Max-Meldrum
Copy link
Contributor

Not that it matters much, but a bit curious why the "-SNAPSHOT" part is there? Requirement by the Arrow project or just an old habit of Java development?

@Dandandan Dandandan merged commit 3665296 into apache:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow version should be 5.0.0-SNAPSHOT
5 participants