Treat DecimalArray as PrimitiveArray in row format #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently failing tests due to #2873 |
alamb
approved these changes
Oct 18, 2022
| @@ -811,6 +809,64 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
viirya
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #2857
Rationale for this change
Now that DecimalArray is just a PrimitiveArray, we can simplify the logic for the row format
What changes are included in this PR?
Changes the row format to no longer special-case decimals, and adds tests
Are there any user-facing changes?
No