Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various invalid_html_tags clippy errors #2862

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Fix various invalid_html_tags clippy errors #2862

merged 1 commit into from
Oct 12, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 12, 2022

Which issue does this PR close?

Closes #2861.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Oct 12, 2022
@viirya viirya mentioned this pull request Oct 12, 2022
Merged
viirya
viirya commented Oct 12, 2022
View reviewed changes
arrow-flight/src/lib.rs
@@ -15,6 +15,8 @@
// specific language governing permissions and limitations
// under the License.

#![allow(rustdoc::invalid_html_tags)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are auto-generated rs file that I cannot modify directly. So allowing it here.

viirya
viirya commented Oct 12, 2022
View reviewed changes
arrow/src/lib.rs
@@ -248,7 +248,7 @@

#![deny(clippy::redundant_clone)]
#![warn(missing_debug_implementations)]

#![allow(rustdoc::invalid_html_tags)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are auto-generated rs file that I cannot modify directly. So allowing it here.

@viirya viirya mentioned this pull request Oct 12, 2022
Merged
Dandandan
Dandandan approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@Dandandan Dandandan merged commit 3bb7f38 into apache:master Oct 12, 2022
@ursabot
Copy link

ursabot commented Oct 12, 2022

Benchmark runs are scheduled for baseline = 0268bba and contender = 3bb7f38. 3bb7f38 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@viirya viirya deleted the fix_clippy branch October 12, 2022 16:47
@alamb alamb mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix various invalid_html_tags clippy error
3 participants
@viirya @ursabot @Dandandan