Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unary kernels to arrow-array (#2787) #2789

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Sep 27, 2022

Which issue does this PR close?

Part of #2787

Rationale for this change

See ticket

What changes are included in this PR?

Moves the unary kernel implementation to arrow-array

Interestingly this actually improves performance for a number of the kernels, even those that don't use unary. My only guess is that by better distributing the codegen, LLVM better optimises the resulting code.

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 27, 2022
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I saw you mentioned binary and try_binary kernels too in the ticket but not in the change here. Will you move them too?

@tustvold
Copy link
Contributor Author

I saw you mentioned binary and try_binary kernels too in the ticket but not in the change here

I need to think a bit more on this, I don't have an immediate need for them just yet, and I would need to move some functions like combine_option_bitmap.

@tustvold tustvold merged commit 2ba1307 into apache:master Sep 27, 2022
@ursabot
Copy link

ursabot commented Sep 27, 2022

Benchmark runs are scheduled for baseline = 333633e and contender = 2ba1307. 2ba1307 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants