-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataType::is_nested() #2707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if some unit test would be helpful ? So that we don't forget it is in the API
Though the test would basically just be a re-implementation so I agree adding it is debatable.
Thanks for this @kfastov -- really nice
Co-authored-by: Liang-Chi Hsieh <[email protected]>
@alamb |
Thanks again @kfastov for the fast turnaround 🐎 |
Benchmark runs are scheduled for baseline = be33fb3 and contender = 0ba5c5b. 0ba5c5b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2704.
Rationale for this change
Already described in the issue
What changes are included in this PR?
is_nested
function is added toDataType
, that returnstrue
if the provided type is nested (List
,FixedSizeList
,LargeList
,Struct
,Union
orMap
)Are there any user-facing changes?
User will be able to use
DataType::is_nested
function