Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple part uploads at once making vector size inconsistent #2681

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Fix multiple part uploads at once making vector size inconsistent #2681

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9bd825
Fix multiple part uploads at once making vector size inconsistent
gruuya Sep 8, 2022
a2d3457
Calculate total_parts prior to resizing the vector
gruuya Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion object_store/src/multipart.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ where
if self.tasks.is_empty() {
return Ok(());
}
let total_parts = self.completed_parts.len();
while let Poll::Ready(Some(res)) = self.tasks.poll_next_unpin(cx) {
let (part_idx, part) = res?;
let total_parts = self.completed_parts.len();
self.completed_parts
.resize(std::cmp::max(part_idx + 1, total_parts), None);
self.completed_parts[part_idx] = Some(part);
Expand Down