Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix test_row_type_validation test #2546

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented Aug 22, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

Since serde_json 1.0.84+, test_row_type_validation fails.

---- json::reader::tests::test_row_type_validation stdout ----                                                     
thread 'json::reader::tests::test_row_type_validation' panicked at 'assertion failed: `(left == right)`                                                                                                                                
  left: `"Json error: Expected JSON record to be an object, found Array [Number(1), String(\"hello\")]"`,                                                                                                                              
 right: `"Json error: Expected JSON record to be an object, found Array([Number(1), String(\"hello\")])"`', arrow/src/json/reader.rs:2624:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace                                   

This is to update the test.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 22, 2022
@viirya viirya merged commit dc1448e into apache:master Aug 22, 2022
@ursabot
Copy link

ursabot commented Aug 22, 2022

Benchmark runs are scheduled for baseline = 34216d5 and contender = dc1448e. dc1448e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Aug 22, 2022

Mailing list context for anyone else who is curious: https://lists.apache.org/thread/7z4x99vlc8cgncf644x1dc7sdmz6np3p (this was found while verifying arrow 21.0.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants