Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FixedSizeBinaryBuilder Constructors #2516

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

psvri
Copy link
Contributor

@psvri psvri commented Aug 19, 2022

Which issue does this PR close?

Partially implements #2054

Rationale for this change

Refactor apis to make a consistent new and with_capacity functions

What changes are included in this PR?

Removes capacity from new and added with_capacity function instead.

Are there any user-facing changes?

Yes

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Aug 19, 2022
@tustvold tustvold changed the title refactoring fixed size binary builder apis Refactor FixedSizeBinaryBuilder Constructors Aug 19, 2022
@tustvold tustvold added the api-change Changes to the arrow API label Aug 19, 2022
@tustvold tustvold merged commit b3fd4bd into apache:master Aug 19, 2022
@ursabot
Copy link

ursabot commented Aug 19, 2022

Benchmark runs are scheduled for baseline = ac8b0eb and contender = b3fd4bd. b3fd4bd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

amrltqt pushed a commit to amrltqt/arrow-rs that referenced this pull request Aug 20, 2022
* refactor FixedSizeBinaryBuilder apis

* Fixing errors
@psvri psvri deleted the fixed_size_builders_refactor branch September 6, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants