Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve markdown format CI check to show diff #2399

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 10, 2022

Draft until I get an example failure with the updated check

Which issue does this PR close?

Closes #1139

Rationale for this change

If the CI markdown check fails, users can apply the diffs manually if they don't want to install npx

What changes are included in this PR?

Update arrow check to be the same as datafusion: https://github.com/apache/arrow-datafusion/blob/a8ed874/.github/workflows/dev.yml#L50-L55

  1. Use --write and git diff instead if --check
  2. Upgrade from [email protected] to [email protected]

Example CI failure

Here is an example of what the CI failure looks like with this change: https://github.com/apache/arrow-rs/runs/7769033182?check_suite_focus=true

Are there any user-facing changes?

No

@alamb alamb marked this pull request as draft August 10, 2022 14:02
@alamb alamb marked this pull request as ready for review August 11, 2022 11:34
@alamb alamb added the development-process Related to development process of arrow-rs label Aug 11, 2022
@tustvold tustvold merged commit 43c6eb7 into apache:master Aug 11, 2022
@ursabot
Copy link

ursabot commented Aug 11, 2022

Benchmark runs are scheduled for baseline = 21ba02e and contender = 43c6eb7. 43c6eb7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting of markdown with Prettier
3 participants