Improve markdown format CI check to show diff #2399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until I get an example failure with the updated checkWhich issue does this PR close?
Closes #1139
Rationale for this change
If the CI markdown check fails, users can apply the diffs manually if they don't want to install
npx
What changes are included in this PR?
Update arrow check to be the same as datafusion: https://github.com/apache/arrow-datafusion/blob/a8ed874/.github/workflows/dev.yml#L50-L55
--write
andgit diff
instead if--check
[email protected]
to[email protected]
Example CI failure
Here is an example of what the CI failure looks like with this change: https://github.com/apache/arrow-rs/runs/7769033182?check_suite_focus=true
Are there any user-facing changes?
No