Remove JsonEqual #2317
Remove JsonEqual #2317
Conversation
github-actions
bot
added
arrow
| } | ||
|
|
||
| /// Construct an Arrow array from a partially typed JSON column | ||
| fn array_from_json( |
There was a problem hiding this comment.
This appears to have just been moved
viirya
force-pushed
the
remove_json_equal
branch
from
a49db10
to
e7270ef
Compare
| @@ -127,7 +127,7 @@ pub fn timestamp_ns_to_datetime(v: i64) -> NaiveDateTime { | |||
| // extract seconds from nanoseconds | |||
| v / NANOSECONDS, | |||
| // discard extracted seconds | |||
| (v % NANOSECONDS) as u32, | |||
| if v > 0 { (v % NANOSECONDS) as u32 } else { 0 }, | |||
There was a problem hiding this comment.
When v is negative, this parameter causes invalid or out-of-range datetime error. Just temporarily avoid the failure here. Other function like timestamp_us_to_datetime might have same issue.
| @@ -945,22 +1258,25 @@ mod tests { | |||
| .len(3) | |||
| .add_buffer(value_offsets) | |||
| .add_child_data(value_data.into_data()) | |||
| .null_bit_buffer(Some(Buffer::from([0b00000011]))) | |||
There was a problem hiding this comment.
This appears to be a bug in previous code. The integration.json specifies validity like the update, but it doesn't reflect that before.
| .len(3) | ||
| .add_child_data(structs_int32s.data().clone()) | ||
| .add_child_data(structs_utf8s.data().clone()) | ||
| .null_bit_buffer(Some(Buffer::from([0b00000011]))) |
There was a problem hiding this comment.
same as to reflect the validity data in integration.json.
viirya
force-pushed
the
remove_json_equal
branch
from
badbabb
to
dae94f2
Compare
|
Benchmark runs are scheduled for baseline = 5166a08 and contender = 2683b06. 2683b06 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2296.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?