Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Target Feature Recommendations to Arrow Crate Docs #2305

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 3, 2022

Continues the process of adding more documentation, this adds a section on how to get LLVM to be slightly less conservative and use instructions from this decade 😆

I put this as the first thing in the crate docs, as I think it is important, and highlights that we care about performance, but happy to move if people feel differently.

@tustvold tustvold added the development-process Related to development process of arrow-rs label Aug 3, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 3, 2022
@tustvold tustvold changed the title More docs Add Target Feature Recommendations to Arrow Crate Docs Aug 3, 2022
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this is useful.

@tustvold tustvold merged commit 2cf4cd8 into apache:master Aug 3, 2022
@ursabot
Copy link

ursabot commented Aug 3, 2022

Benchmark runs are scheduled for baseline = f78d2e6 and contender = 2cf4cd8. 2cf4cd8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

//! particularly for x86_64, favour portability over performance, and LLVM will consequently avoid
//! using more recent instructions that would result in errors on older CPUs.
//!
//! To address this it is recommended that you specify the override the LLVM defaults either
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops wording error here, will fix 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants