-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve object_store crate
documentation
#2260
Conversation
object_store crate
documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, thank you for doing this
A focused, easy to use, idiomatic, high performance, `async` object | ||
store library interacting with object stores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A focused, easy to use, idiomatic, high performance, `async` object | |
store library interacting with object stores. | |
A high performance, `async` object store crate that provides a | |
uniform interface for interacting with various kinds of object store |
I think all the qualifiers is a bit much 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am practicing "marketing" -- I would like to run an experiment to see how much attention I can garner with a buzzword laden lead compared to a more utilitarian, less self-aggrandizing, summary.
Co-authored-by: Raphael Taylor-Davies <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2260 +/- ##
=======================================
Coverage 82.28% 82.28%
=======================================
Files 245 245
Lines 62670 62688 +18
=======================================
+ Hits 51567 51585 +18
Misses 11103 11103
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice write up! 😊
Thanks @Ted-Jiang ! |
Benchmark runs are scheduled for baseline = 6bb4b5e and contender = 3e17891. 3e17891 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2202
Rationale for this change
More docs
==
more betterWhat changes are included in this PR?
Example front page:
Are there any user-facing changes?
Better docs